Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[type:fixbug]HTTP registration is not configured and registration metadata is wrong #4889

Merged
merged 10 commits into from Jul 24, 2023

Conversation

li-keguo
Copy link
Member

@li-keguo li-keguo commented Jul 23, 2023

work list :

  • HTTP registration is added to the configuration.
  • Fixed the issue of registering some APIs.

# Conflicts:
#	shenyu-client/shenyu-client-core/src/main/java/org/apache/shenyu/client/core/register/matcher/BaseAnnotationApiProcessor.java
#	shenyu-client/shenyu-client-core/src/main/java/org/apache/shenyu/client/core/register/registrar/BaseApiRegistrarImpl.java
#	shenyu-client/shenyu-client-core/src/main/java/org/apache/shenyu/client/core/register/registrar/MateDataApiRegistrarImplImpl.java
#	shenyu-client/shenyu-client-core/src/main/java/org/apache/shenyu/client/core/register/registrar/UriApiRegistrarImplImpl.java
@li-keguo li-keguo changed the title Fixbug/http register [type:fixbug]HTTP registration is not configured and registration metadata is wrong Jul 23, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jul 23, 2023

Codecov Report

Merging #4889 (8755635) into master (a921bcf) will decrease coverage by 0.09%.
The diff coverage is 25.97%.

@@             Coverage Diff              @@
##             master    #4889      +/-   ##
============================================
- Coverage     64.34%   64.25%   -0.09%     
  Complexity     8228     8228              
============================================
  Files          1166     1167       +1     
  Lines         34271    34330      +59     
  Branches       3074     3083       +9     
============================================
+ Hits          22050    22058       +8     
- Misses        10463    10512      +49     
- Partials       1758     1760       +2     
Impacted Files Coverage Δ
...ent/core/register/matcher/ApiDocProcessorImpl.java 0.00% <0.00%> (ø)
...nyu/client/core/register/matcher/ApiProcessor.java 0.00% <0.00%> (ø)
...u/client/core/register/registrar/ApiRegistrar.java 0.00% <0.00%> (ø)
.../core/register/registrar/BaseApiRegistrarImpl.java 0.00% <0.00%> (ø)
...gister/registrar/MateDataApiRegistrarImplImpl.java 0.00% <0.00%> (ø)
...register/ShenyuSpringCloudClientProcessorImpl.java 0.00% <0.00%> (ø)
...r/register/ShenyuSpringMvcClientProcessorImpl.java 0.00% <0.00%> (ø)
...nyuSpringCloudClientInfoRegisterConfiguration.java 0.00% <0.00%> (ø)
...henyuSpringMvcClientInfoRegisterConfiguration.java 0.00% <0.00%> (ø)
...rg/apache/shenyu/client/core/register/ApiBean.java 51.00% <100.00%> (+1.00%) ⬆️
... and 4 more

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@yu199195 yu199195 merged commit a6e150b into apache:master Jul 24, 2023
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants