Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #4686] nacos client offline #4890

Merged
merged 5 commits into from Jul 24, 2023

Conversation

847850277
Copy link
Contributor

this pr can manage the execution order of hooks,
Although the offline interface has been implemented, the org.apache.shenyu.register.client.server.nacos.NacosClientServerRegisterRepository#subscribeRpcTypeService
still calls when offline, just refreshURIService . and the offline function of Nacos has not yet been fully implemented. We need to discuss how to implement this block.

image

@dragon-zhang

Make sure that:

  • You have read the contribution guidelines.
  • You submit test cases (unit or integration tests) that back your changes.
  • Your local test passed ./mvnw clean install -Dmaven.javadoc.skip=true.

@codecov-commenter
Copy link

codecov-commenter commented Jul 24, 2023

Codecov Report

Merging #4890 (13103e7) into master (7178b82) will decrease coverage by 0.19%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##             master    #4890      +/-   ##
============================================
- Coverage     64.17%   63.98%   -0.19%     
- Complexity     8230     8234       +4     
============================================
  Files          1167     1168       +1     
  Lines         34379    34459      +80     
  Branches       3084     3091       +7     
============================================
- Hits          22064    22050      -14     
- Misses        10556    10652      +96     
+ Partials       1759     1757       -2     
Impacted Files Coverage Δ
...r/subcriber/ShenyuClientURIExecutorSubscriber.java 0.00% <0.00%> (ø)
...client/core/shutdown/ShenyuClientShutdownHook.java 0.00% <0.00%> (ø)
...enyu/client/core/shutdown/ShutdownHookManager.java 0.00% <0.00%> (ø)
...er/client/nacos/NacosClientRegisterRepository.java 73.56% <0.00%> (-26.44%) ⬇️

... and 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@loongs-zhang loongs-zhang merged commit 78dad37 into apache:master Jul 24, 2023
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants