Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix:bug] Fix admin sync bug #4941

Merged
merged 8 commits into from Aug 2, 2023
Merged

Conversation

yunlongn
Copy link
Member

@yunlongn yunlongn commented Aug 1, 2023

Make sure that:

  • You have read the contribution guidelines.
  • You submit test cases (unit or integration tests) that back your changes.
  • Your local test passed ./mvnw clean install -Dmaven.javadoc.skip=true.

@codecov-commenter
Copy link

codecov-commenter commented Aug 1, 2023

Codecov Report

Merging #4941 (c664868) into master (402594a) will increase coverage by 0.03%.
Report is 1 commits behind head on master.
The diff coverage is 60.00%.

@@             Coverage Diff              @@
##             master    #4941      +/-   ##
============================================
+ Coverage     63.92%   63.95%   +0.03%     
+ Complexity     8553     8529      -24     
============================================
  Files          1207     1207              
  Lines         35913    35895      -18     
  Branches       3222     3219       -3     
============================================
+ Hits          22957    22958       +1     
+ Misses        11110    11084      -26     
- Partials       1846     1853       +7     
Files Changed Coverage Δ
...ice/converter/AbstractSelectorHandleConverter.java 4.16% <0.00%> (-79.17%) ⬇️
...henyu/admin/service/impl/UpstreamCheckService.java 66.47% <0.00%> (+8.19%) ⬆️
...egister/ShenyuClientRegisterDivideServiceImpl.java 43.75% <100.00%> (-13.66%) ⬇️
...register/ShenyuClientRegisterDubboServiceImpl.java 70.00% <100.00%> (+3.33%) ⬆️
.../register/ShenyuClientRegisterGrpcServiceImpl.java 70.00% <100.00%> (-7.78%) ⬇️
...er/ShenyuClientRegisterSpringCloudServiceImpl.java 71.87% <100.00%> (+3.45%) ⬆️
.../register/ShenyuClientRegisterTarsServiceImpl.java 68.96% <100.00%> (+0.39%) ⬆️
...nyu/common/dto/convert/selector/DubboUpstream.java 73.61% <100.00%> (ø)

... and 5 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@loongs-zhang loongs-zhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hashCode also need modify.

@moremind moremind merged commit 3082629 into apache:master Aug 2, 2023
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants