Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[type: feature] Support isBlank #4983

Merged
merged 15 commits into from Aug 17, 2023
Merged

[type: feature] Support isBlank #4983

merged 15 commits into from Aug 17, 2023

Conversation

kerwin612
Copy link
Member

Added BlankPredicateJudge class to support isBlank predicate

Make sure that:

  • You have read the contribution guidelines.
  • You submit test cases (unit or integration tests) that back your changes.
  • Your local test passed ./mvnw clean install -Dmaven.javadoc.skip=true.

@kerwin612 kerwin612 changed the title Support isBlank [type: feature] Support isBlank Aug 10, 2023
@kerwin612
Copy link
Member Author

Can anyone respond to this PR? I created it in version 2.6.0, but now it's 2.6.1. 😂

@codecov-commenter
Copy link

codecov-commenter commented Aug 13, 2023

Codecov Report

Merging #4983 (c45df1f) into master (184e4ba) will increase coverage by 0.02%.
Report is 1 commits behind head on master.
The diff coverage is 88.88%.

@@             Coverage Diff              @@
##             master    #4983      +/-   ##
============================================
+ Coverage     64.19%   64.21%   +0.02%     
- Complexity     8568     8574       +6     
============================================
  Files          1208     1209       +1     
  Lines         35900    35905       +5     
  Branches       3218     3219       +1     
============================================
+ Hits          23046    23058      +12     
+ Misses        10997    10988       -9     
- Partials       1857     1859       +2     
Files Changed Coverage Δ
...pache/shenyu/admin/model/dto/RuleConditionDTO.java 81.48% <ø> (ø)
...g/apache/shenyu/admin/service/SelectorService.java 12.50% <ø> (+1.38%) ⬆️
...in/base/condition/judge/PredicateJudgeFactory.java 75.00% <80.00%> (-25.00%) ⬇️
...a/org/apache/shenyu/common/enums/OperatorEnum.java 95.83% <100.00%> (+0.18%) ⬆️
...ugin/base/condition/judge/BlankPredicateJudge.java 100.00% <100.00%> (ø)

... and 5 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@li-keguo
Copy link
Member

relevancy

apache/shenyu-dashboard#312

@li-keguo li-keguo requested a review from moremind August 14, 2023 15:00
@moremind moremind added this to the 2.6.1 milestone Aug 14, 2023
@moremind
Copy link
Member

copy new sql named 2.6.1 from 2.6.0.sql, and add these fields to 2.6.1.sql and 2.6.0-to-2.6.1.sql

@moremind
Copy link
Member

moremind commented Aug 16, 2023

sorry, my means make a mistake, you must add it in init sql

@moremind
Copy link
Member

sorry, my means make a mistake, you must add it in init sql

why need isBlank?

@kerwin612
Copy link
Member Author

sorry, my means make a mistake, you must add it in init sql

why need isBlank?

With isBlank, I can do something when the parameter doesn't contain special field.

moremind
moremind previously approved these changes Aug 16, 2023
@moremind
Copy link
Member

you need to add the field in opengauss database

@moremind
Copy link
Member

you need to add the field in opengauss database

need 2.6.0-2.6.1-og.sql

@dengliming dengliming merged commit efd5f41 into apache:master Aug 17, 2023
42 checks passed
@dengliming dengliming added the type: enhancement New feature or request label Aug 17, 2023
@kerwin612 kerwin612 deleted the support-isBlank branch August 17, 2023 03:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants