Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[refactor] Optimizing the node type listener #5435

Merged
merged 8 commits into from
Feb 24, 2024

Conversation

hql0312
Copy link
Contributor

@hql0312 hql0312 commented Feb 4, 2024

Optimizing gateway admin apollo/nacos start to load data every time.

if had load data from db, it should not load again next time.

@codecov-commenter
Copy link

codecov-commenter commented Feb 5, 2024

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (8886e31) 60.97% compared to head (ef9a92e) 60.98%.

Files Patch % Lines
...u/admin/listener/apollo/ApolloDataChangedInit.java 0.00% 3 Missing ⚠️
...shenyu/admin/listener/utils/NodeDataPathUtils.java 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master    #5435   +/-   ##
=========================================
  Coverage     60.97%   60.98%           
- Complexity     8620     8621    +1     
=========================================
  Files          1258     1259    +1     
  Lines         38426    38432    +6     
  Branches       3679     3679           
=========================================
+ Hits          23430    23436    +6     
  Misses        12881    12881           
  Partials       2115     2115           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yu199195 yu199195 merged commit 05d3bf0 into apache:master Feb 24, 2024
55 checks passed
@hql0312 hql0312 deleted the apollo-listener branch February 25, 2024 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants