Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Variable interpolation section on configuration doc #82

Merged
merged 1 commit into from May 19, 2021
Merged

Variable interpolation section on configuration doc #82

merged 1 commit into from May 19, 2021

Conversation

weltonrodrigo
Copy link
Contributor

This is a very useful feature for the docker world, but couldn't find any information about it in the docs.

Also, please note that the footer link "Edit this Page on Github" is pointing to branch master instead of the new main, this results in a 404 error.

@weltonrodrigo weltonrodrigo changed the title Patch 2 Variable interpolation section on configuration doc May 18, 2021
@weltonrodrigo weltonrodrigo mentioned this pull request May 18, 2021
Merged
bmarwell
bmarwell approved these changes May 18, 2021
View reviewed changes
Copy link
Contributor

@bmarwell bmarwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bmarwell
Copy link
Contributor

@weltonrodrigo thanks a lot for your PR!
I think you could squash the commits, they are short enough.

@weltonrodrigo
Copy link
Contributor Author

@weltonrodrigo thanks a lot for your PR!
I think you could squash the commits, they are short enough.

Done.

bdemers
bdemers reviewed May 18, 2021
View reviewed changes
configuration.md.vtl Outdated Show resolved Hide resolved
bdemers
bdemers reviewed May 18, 2021
View reviewed changes
configuration.md.vtl Outdated Show resolved Hide resolved
bdemers
bdemers reviewed May 18, 2021
View reviewed changes
configuration.md.vtl Outdated Show resolved Hide resolved
bdemers
bdemers approved these changes May 18, 2021
View reviewed changes
Copy link
Member

@bdemers bdemers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a couple of nits but this is great (and it fills a hole in the docs!!)

@bdemers
Copy link
Member

bdemers commented May 18, 2021

Thanks @weltonrodrigo !!

@bdemers
Copy link
Member

bdemers commented May 18, 2021

Also, we have an update for the master to main issue you noticed in the Edit link, you caught us mid migration 😄

fpapon
fpapon approved these changes May 18, 2021
View reviewed changes
Copy link
Member

@fpapon fpapon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@weltonrodrigo @bdemers
Add explanation about variable interpolation
8b5b4ac 
This is a very useful feature for the docker world,
but couldn't find any information about it in the docs.

Co-authored-by: Brian Demers <brian.demers@gmail.com>
@weltonrodrigo
Copy link
Contributor Author

Accepted changes and squashed.

@fpapon fpapon merged commit 1817f5a into apache:main May 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdemers bdemers bdemers approved these changes

@bmarwell bmarwell bmarwell approved these changes

@fpapon fpapon fpapon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@weltonrodrigo @bmarwell @bdemers @fpapon