Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up compiler warnings #1004

Closed
lprimak opened this issue Jul 11, 2023 · 7 comments · Fixed by #1233
Closed

Clean up compiler warnings #1004

lprimak opened this issue Jul 11, 2023 · 7 comments · Fixed by #1233
Assignees
@lprimak

Comments

@lprimak
Copy link
Contributor

lprimak commented Jul 11, 2023

Currently, there around 300 warnings in the code, they should be cleaned up
@lprimak lprimak added good-first-issue Good First Issue help-wanted Help Wanted labels Jul 11, 2023
@lprimak lprimak changed the title Clean up compiler warnings in main Clean up compiler warnings Jul 11, 2023
@lprimak lprimak mentioned this issue Jul 11, 2023
Closed
@bmarwell
Copy link
Contributor

We can add -processing as a start

@seanpmcn
Copy link

seanpmcn commented Aug 2, 2023

The enum ProvidedHashFormat contains enum values for HexFormat and Base64Format which have been deprecated in org.apache.shiro.crypto.hash.format. Could references to these enum values simply be removed?

seanpmcn added a commit to seanpmcn/shiro that referenced this issue Aug 2, 2023
@seanpmcn
[apache#1004] Update deprecated Lookups, replace AbstractHash impleme…
65b8457 
…ntation with SimpleHash, update deprecated method newInstance
seanpmcn added a commit to seanpmcn/shiro that referenced this issue Aug 7, 2023
@seanpmcn
[apache#1004] Address AbstractHash issues by updating to SimpleHash
ff68fd6
@seanpmcn
Copy link

Which warnings does this issue refer to, because there is a different amount depending on what you're looking at.

@lprimak
Copy link
Contributor Author

lprimak commented Aug 11, 2023

Get the simple stuff done first. Leave more complicated stuff for later

seanpmcn added a commit to seanpmcn/shiro that referenced this issue Aug 13, 2023
@seanpmcn
[apache#1004] Address AbstractHash issues by updating to SimpleHash
e3bf49c
seanpmcn added a commit to seanpmcn/shiro that referenced this issue Aug 13, 2023
@seanpmcn
[apache#1004] Remove wildcard
b6e5322
seanpmcn added a commit to seanpmcn/shiro that referenced this issue Aug 13, 2023
@seanpmcn
[apache#1004] Add SuppressWarning to test for deprecated class and up…
2c31f9c 
…date instantiation of Security Manager
@lprimak
Copy link
Contributor Author

lprimak commented Oct 4, 2023

Hi, @seanpmcn
Do you have an update?
Thank you

@seanpmcn
Copy link

seanpmcn commented Oct 4, 2023

@lprimak
Sorry about the lack of update.
I got caught up in work for grad school. I think I may need to step back from this one and let others take care of it.

I hope that's alright. I'm still getting used to the etiquette and protocols of open source.

@lprimak
Copy link
Contributor Author

lprimak commented Oct 4, 2023

That's not a problem. You are welcome to pick up issues when you can.

@lprimak lprimak mentioned this issue Oct 4, 2023
Closed
10 tasks
@lprimak lprimak mentioned this issue Dec 16, 2023
Merged
10 tasks
@lprimak lprimak removed good-first-issue Good First Issue help-wanted Help Wanted labels Dec 17, 2023
@lprimak lprimak self-assigned this Dec 17, 2023
lprimak added a commit that referenced this issue Dec 21, 2023
@lprimak
Merge pull request #1233 from lprimak/fix-compiler-warnings
870443b 
[#1004] - Remove compiler warnings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lprimak lprimak

Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@lprimak @bmarwell @seanpmcn