Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the Maven Central badge #1042

Merged
merged 2 commits into from Aug 23, 2023
Merged

Fix the Maven Central badge #1042

merged 2 commits into from Aug 23, 2023

Conversation

marcelstoer
Copy link
Contributor

The badge should actually link to Central.

Following this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GitHub issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a GitHub issue. Your pull request should address just this issue, without pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [#XXX] - Fixes bug in SessionManager,
    where you replace #XXX with the appropriate GitHub issue. Best practice
    is to use the GitHub issue title in the pull request title and in the first line of the commit message.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • add fixes #XXX if merging the PR should close a related issue.
  • Run mvn verify to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If you have a group of commits related to the same change, please squash your commits into one and force push your branch using git rebase -i.
  • Committers: Make sure a milestone is set on the PR

Trivial changes like typos do not require a GitHub issue (javadoc, comments...).
In this case, just format the pull request title like [DOC] - Add javadoc in SessionManager.

If this is your first contribution, you have to read the Contribution Guidelines

If your pull request is about ~20 lines of code you don't need to sign an Individual Contributor License Agreement
if you are unsure please ask on the developers list.

To make clear that you license your contribution under the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

The badge should actually link to Central.
@bdemers
Copy link
Member

bdemers commented Aug 23, 2023

Awesome! thanks @marcelstoer

@marcelstoer
Copy link
Contributor Author

Using https://github.com/softwaremill/maven-badges instead of shields.io for the Maven badge would give us a little more convenience but I deemed my current fix good enough for most.

Copy link
Contributor

@lprimak lprimak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be https://central.sonatype.com/ instead?

@marcelstoer
Copy link
Contributor Author

marcelstoer commented Aug 23, 2023

I have no preference, we might just as well link to https://central.sonatype.com/artifact/org.apache.shiro/shiro-core/ instead. However, I somehow feel that search.maven.org is going to be stable far longer than central.sonatype.com.

@lprimak
Copy link
Contributor

lprimak commented Aug 23, 2023

Well, it's a redirect now, so I feel like sonatype.org would better. I talked to some folks at sonatype and they say "big changs" are coming, so I would say the new stuff is gonna stick around :)

@lprimak lprimak merged commit 971ad65 into apache:main Aug 23, 2023
1 check passed
@marcelstoer marcelstoer deleted the main-1 branch August 23, 2023 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants