Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1005] - Expand checkstyle to all modules (root). #1069

Merged
merged 1 commit into from Oct 5, 2023

Conversation

damonxue
Copy link

@damonxue damonxue commented Sep 10, 2023

fixes #1005
Reformatted all the code to conform to checkstyle rules

If your pull request is about ~20 lines of code you don't need to sign an Individual Contributor License Agreement

Following this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GitHub issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a GitHub issue. Your pull request should address just this issue, without pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [#XXX] - Fixes bug in SessionManager,
    where you replace #XXX with the appropriate GitHub issue. Best practice
    is to use the GitHub issue title in the pull request title and in the first line of the commit message.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • add fixes #XXX if merging the PR should close a related issue.
  • Run mvn verify to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If you have a group of commits related to the same change, please squash your commits into one and force push your branch using git rebase -i.
  • Committers: Make sure a milestone is set on the PR

Trivial changes like typos do not require a GitHub issue (javadoc, comments...).
In this case, just format the pull request title like [DOC] - Add javadoc in SessionManager.

If this is your first contribution, you have to read the Contribution Guidelines

If your pull request is about ~20 lines of code you don't need to sign an Individual Contributor License Agreement
if you are unsure please ask on the developers list.

To make clear that you license your contribution under the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

@damonxue damonxue marked this pull request as draft September 10, 2023 14:58
@damonxue
Copy link
Author

#1059

@damonxue damonxue closed this Sep 10, 2023
@damonxue damonxue reopened this Sep 12, 2023
@damonxue damonxue marked this pull request as ready for review September 12, 2023 05:32
@damonxue
Copy link
Author

  • The reason for formatting too many files is to make sure that they all end with 'lf'.

    I rolled back *.md, *.yml and others not need formatted.

  • I will change too many 'lineLength'.

@lprimak @bmarwell pls review.

@lprimak lprimak self-requested a review September 28, 2023 00:14
@lprimak lprimak self-assigned this Sep 28, 2023
@lprimak lprimak added pending-cla shiro-2.0.0 java Pull requests that update Java code core Core Modules labels Sep 28, 2023
@lprimak lprimak added this to the 2.0 milestone Sep 28, 2023
@lprimak lprimak changed the title [#ISSUE 1005] - Expand checkstyle to all modules (root). [#1005] - Expand checkstyle to all modules (root). Sep 28, 2023
@lprimak
Copy link
Contributor

lprimak commented Oct 3, 2023

Hi, @damonxue
Can you please check the license-related boxes in the PR that I have updated.
Thank you

@lprimak
Copy link
Contributor

lprimak commented Oct 3, 2023

I have started the review process. So far it looks great!

@lprimak
Copy link
Contributor

lprimak commented Oct 4, 2023

One comment:
You are still trying to do way too much. I will fix it up, but you are just creating extra work for the reviewers unnecessarily.
Because you reformatted pretty much every file (many unnecessarily) you have trampled on some recent changes.

@lprimak
Copy link
Contributor

lprimak commented Oct 4, 2023

Also, please do not close this PR, force-push or open another one, or make more massive changes. I can't devote 5+ hours to start from the beginning again.

Thank you!

Overall, great job, we are close to approval.

@fpapon fpapon self-requested a review October 4, 2023 05:51
Copy link
Member

@fpapon fpapon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@damonxue can you squash the commits and rebase from main?

@fpapon
Copy link
Member

fpapon commented Oct 4, 2023

@damonxue thank you for the great work!

@lprimak
Copy link
Contributor

lprimak commented Oct 4, 2023

@damonxue please don't squash the commit just yet. I will let you know. I am not done with my review / changes.
Once I am done, I will let you know, or maybe do it myself :)

@lprimak
Copy link
Contributor

lprimak commented Oct 4, 2023

@damonxue I am done with my changes. Feel free to squash the commits, or let me know if you want me to do it.
Either way is fine with me.

Copy link
Contributor

@lprimak lprimak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@lprimak
Copy link
Contributor

lprimak commented Oct 5, 2023

I have rebased & squashed the commits. Should be good to go tomorrow :)

@lprimak lprimak requested a review from fpapon October 5, 2023 01:50
@lprimak lprimak merged commit cf53ba0 into apache:main Oct 5, 2023
22 checks passed
@damonxue damonxue deleted the checkstyle_test_1 branch October 6, 2023 03:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA core Core Modules java Pull requests that update Java code shiro-2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expand checkstyle to all modules (root)
3 participants