Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Initial commit for openid4j support #46

Closed
wants to merge 1 commit into from
Closed

Conversation

bdemers
Copy link
Member

@bdemers bdemers commented Nov 8, 2016

Moved this commit from master into a branch until feature is complete

@hubot hubot deleted the openid4j branch April 28, 2017 14:49
@hubot hubot restored the openid4j branch April 28, 2017 22:10
@fpapon
Copy link
Member

fpapon commented May 29, 2020

@bdemers it would be nice to have this in the 2.0.0 :)
Thoughts?

@bdemers bdemers added this to the 2.0 milestone May 29, 2020
@bdemers
Copy link
Member Author

bdemers commented May 29, 2020

IMHO, OAuth2 (and OIDC) is a must-have for 2.0. I think the openid4j project is dead though.
But... it's a good start of where the bits need to be plugged in.

I've been thinking about options in the back of my head for a while now. And I need to start writing them down (both code and on the dev list). I'll add a note here for now, because i'm thinking about it.

There are a couple of main use cases we need to target (and even more nice-to-haves)

  • Resource Server support - Shiro has Bearer Token support for this, which is half the battle, we could add "opaque" access token validation as a Realm.
    I worry about generic JWT access token validation as each vendor recommends different validation (as JWTs are NOT part of the OAuth spec), but other libraries have support, so...

  • OAuth 2.0 Auth Code Flow - there will be a heavy dependency on the servlet (or similar) specs for this

  • OIDC support (similar to previous)

All of these options depend on an HTTP client component which Shiro doesn't have. It's easy enough to add, but we may need to expose some of the underlying bits of said client, to allow for a whole host of client-to-server communication. (timeouts, HTTP headers for firewall negation, proxies, etc).

Mostly just quick thoughts, I need to dig into this again

@fpapon
Copy link
Member

fpapon commented May 29, 2020

IMHO, OAuth2 (and OIDC) is a must-have for 2.0. I think the openid4j project is dead though.
But... it's a good start of where the bits need to be plugged in.

I've been thinking about options in the back of my head for a while now. And I need to start writing them down (both code and on the dev list). I'll add a note here for now, because i'm thinking about it.

There are a couple of main use cases we need to target (and even more nice-to-haves)

* Resource Server support - Shiro has Bearer Token support for this, which is half the battle, we could add "opaque" access token validation as a Realm.
  I worry about generic JWT access token validation as each vendor recommends different validation (as JWTs are NOT part of the OAuth spec), but other libraries have support, so...

* OAuth 2.0 Auth Code Flow - there will be a heavy dependency on the servlet (or similar) specs for this

* OIDC support (similar to previous)

All of these options depend on an HTTP client component which Shiro doesn't have. It's easy enough to add, but we may need to expose some of the underlying bits of said client, to allow for a whole host of client-to-server communication. (timeouts, HTTP headers for firewall negation, proxies, etc).

Mostly just quick thoughts, I need to dig into this again

Nice, you can add on the brainstorm page on Confluence (until I have my access rights :) ).
So we can close this PR IHMO.

@bdemers
Copy link
Member Author

bdemers commented May 29, 2020

Done! https://cwiki.apache.org/confluence/display/SHIRO/Version+2+Brainstorming#Version2Brainstorming-OAuth2.0Support

@bdemers bdemers closed this May 29, 2020
@bmarwell bmarwell deleted the openid4j branch June 25, 2020 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants