Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for direct configuration of ShiroFilter through WebEnvironment #518

Merged
merged 2 commits into from Nov 2, 2022

Conversation

bdemers
Copy link
Member

@bdemers bdemers commented Oct 28, 2022

Adds new ShiroFilterConfiguration class exposed through the WebEnvironment
This class allows for confiuration of the Shiro filter through various config mechanisms (Ini, Guice, Spring, etc)
This makes it easer to enable a static security manager when using Shiro's Servlet fragment, as now a web.xml is not required

Backport: 28e10e0

Adds new ShiroFilterConfiguration class exposed through the WebEnvironment
This class allows for confiuration of the Shiro filter through various config mechanisms (Ini, Guice, Spring, etc)
This makes it easer to enable a static security manager when using Shiro's Servlet fragment, as now a web.xml is not required

Backport: 28e10e0
@bdemers
Copy link
Member Author

bdemers commented Oct 28, 2022

This should wait for #519 to be merged.

Copy link
Contributor

@bmarwell bmarwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! You even rewrote the whole test, which is great! Just a nit about star imports, I'd like to keep the former code style (so it's consistent). Maybe we should discuss light auto-formatting.

@@ -70,8 +70,10 @@ public class ShiroFilter extends AbstractShiroFilter {
*/
@Override
public void init() throws Exception {

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?

@bdemers bdemers force-pushed the back-port-shiro-filter-config branch 2 times, most recently from 571811d to 8cc9f8c Compare November 1, 2022 16:38
@bdemers bdemers force-pushed the back-port-shiro-filter-config branch from 8cc9f8c to 37f4791 Compare November 1, 2022 16:44
@bdemers
Copy link
Member Author

bdemers commented Nov 1, 2022

Fixed imports.

@bmarwell bmarwell merged commit 3203c8f into main Nov 2, 2022
@bmarwell bmarwell deleted the back-port-shiro-filter-config branch November 2, 2022 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants