Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SHIRO-900] Refactor and update pom.xml #574

Merged
merged 1 commit into from Jan 10, 2023

Conversation

lprimak
Copy link
Contributor

@lprimak lprimak commented Dec 19, 2022

  • Update Apache parent to 29 from 28
  • Factor out jacoco properties and separate from maven surefire / failsafe argLine
  • Update Groovy from Codehaus to Apache Groovy (4.x)
  • Updade gmaven groovy plugin
  • Update maven versions plugin
  • Add compiler deprecation and unchecked lint by default
  • Add JDK 11+ options for surefire and failsafe plugins

Following this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a JIRA issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [SHIRO-XXX] - Fixes bug in SessionManager,
    where you replace SHIRO-XXX with the appropriate JIRA issue. Best practice
    is to use the JIRA issue title in the pull request title and in the first line of the commit message.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean install apache-rat:check to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If you have a group of commits related to the same change, please squash your commits into one and force push your branch using git rebase -i.

Trivial changes like typos do not require a JIRA issue (javadoc, comments...).
In this case, just format the pull request title like (DOC) - Add javadoc in SessionManager.

If this is your first contribution, you have to read the Contribution Guidelines

If your pull request is about ~20 lines of code you don't need to sign an Individual Contributor License Agreement
if you are unsure please ask on the developers list.

To make clear that you license your contribution under the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

@lprimak lprimak changed the title added jdk11+ profile and apropriate failsafe and surefire options [SHIRO-900] Refactor pom.xml and add features Dec 21, 2022
@lprimak lprimak changed the title [SHIRO-900] Refactor pom.xml and add features [SHIRO-900] Refactor and update pom.xml Dec 21, 2022
@lprimak lprimak marked this pull request as ready for review December 21, 2022 19:15
@lprimak lprimak force-pushed the jdk11-improvements branch 3 times, most recently from 4231443 to 292c8c8 Compare December 22, 2022 02:34
Copy link
Contributor

@bmarwell bmarwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Request for the profile (last 2 comments), rest is only comments/questions.

pom.xml Outdated Show resolved Hide resolved
pom.xml Outdated Show resolved Hide resolved
pom.xml Outdated Show resolved Hide resolved
pom.xml Outdated Show resolved Hide resolved
pom.xml Outdated Show resolved Hide resolved
pom.xml Outdated Show resolved Hide resolved
@lprimak lprimak force-pushed the jdk11-improvements branch 4 times, most recently from 5103087 to 83afd6e Compare December 23, 2022 05:47
@lprimak lprimak changed the title [SHIRO-900] Refactor and update pom.xml [SHIRO-900] (wip) Refactor and update pom.xml Dec 23, 2022
@lprimak lprimak force-pushed the jdk11-improvements branch 3 times, most recently from 091a506 to 7673f36 Compare December 24, 2022 07:39
@lprimak lprimak dismissed bmarwell’s stale review December 24, 2022 07:39

all changes have been performed

@lprimak lprimak changed the title [SHIRO-900] (wip) Refactor and update pom.xml [SHIRO-900] Refactor and update pom.xml Dec 24, 2022
@lprimak lprimak changed the title [SHIRO-900] Refactor and update pom.xml [SHIRO-900] (wip) Refactor and update pom.xml Dec 24, 2022
@lprimak lprimak changed the title [SHIRO-900] (wip) Refactor and update pom.xml [SHIRO-900] Refactor and update pom.xml Dec 24, 2022
pom.xml Outdated Show resolved Hide resolved
@lprimak lprimak self-assigned this Dec 30, 2022
@lprimak lprimak added shiro-2.0.0 dependencies Pull requests that update a dependency file labels Dec 30, 2022
@lprimak lprimak force-pushed the jdk11-improvements branch 2 times, most recently from 8152ae7 to 2ec56b8 Compare December 31, 2022 06:51
Copy link
Contributor

@bmarwell bmarwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, maybe add the comment but that doesn't prevent you from merging imho.

pom.xml Show resolved Hide resolved
pom.xml Show resolved Hide resolved
Copy link
Member

@fpapon fpapon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lprimak good job!

@lprimak lprimak merged commit e3c56b5 into apache:main Jan 10, 2023
@lprimak lprimak deleted the jdk11-improvements branch January 10, 2023 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file shiro-2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants