Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support in and notIn for stringArray #27

Merged
merged 3 commits into from
Dec 17, 2022
Merged

Conversation

lujiajing1126
Copy link
Contributor

Closes apache/skywalking#10165

  • Add in and notIn support for StringArr

@lujiajing1126 lujiajing1126 added the enhancement New feature or request label Dec 17, 2022
@lujiajing1126 lujiajing1126 added this to the 0.3.0 milestone Dec 17, 2022
@lujiajing1126 lujiajing1126 self-assigned this Dec 17, 2022
Comment on lines 41 to 43
.setName(this.tagAndValue.getTagName())
.setOp(this.op)
.setValue(this.tagAndValue.buildTypedTagValue()).build())
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These format changes seem odd

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reverted now

@hanahmily hanahmily merged commit eb0504e into main Dec 17, 2022
@hanahmily hanahmily deleted the feature/support-in-op branch December 17, 2022 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
3 participants