Tweak Group builders for property operations #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gao Hongtao <hanahmily@gmail.com>
|
The issue is in the 9.4.0 OAP, do you plan another 0.3.1 client release after this? |
|
It looks like I have to release 0.3.1 once this commit gets merged.
…On Thu, Feb 23, 2023 at 23:19 吴晟 Wu Sheng ***@***.***> wrote:
The issue is in the 9.4.0 OAP, do you plan another 0.3.1 client release
after this?
—
Reply to this email directly, view it on GitHub
<#36 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAO6UWIF43353ZYW53N6ECTWY55WLANCNFSM6AAAAAAVFYPOVQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
Let's do that. I just feel maybe we will need 0.3.2 for topN(only feeling :P) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is related to apache/skywalking#10413.
The client validated the nullable fields of a
Group. In this commit, I removed those checkers, adding newcreatefunctions to build groups for storing properties.I also update IT's banyandb sha to verify the changes on v0.3.1.