Remove term metadata store #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gao Hongtao <hanahmily@gmail.com>
lujiajing1126
approved these changes
Jul 29, 2022
|
For a reduced term dictionary key. The raw key length could be more than 8
bytes which is the fixed length of a ID
…On Fri, Jul 29, 2022 at 11:48 PM Jiajing LU ***@***.***> wrote:
***@***.**** approved this pull request.
LGTM. A question: why do we intend to initially convert raw value bytes to
a hash id?
—
Reply to this email directly, view it on GitHub
<#148 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAO6UWIVWUJGYHMTOGCHCB3VWP4NHANCNFSM55A5EWMA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes apache/skywalking#9405
This change frees up ~20% of memory.
Signed-off-by: Gao Hongtao hanahmily@gmail.com