Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tsdb's leaked goroutines #154

Merged
merged 2 commits into from
Aug 11, 2022
Merged

Fix tsdb's leaked goroutines #154

merged 2 commits into from
Aug 11, 2022

Conversation

hanahmily
Copy link
Contributor

Fixes apache/skywalking#9458

Signed-off-by: Gao Hongtao hanahmily@gmail.com

Signed-off-by: Gao Hongtao <hanahmily@gmail.com>
@hanahmily hanahmily added this to the 0.2.0 milestone Aug 11, 2022
Signed-off-by: Gao Hongtao <hanahmily@gmail.com>
@codecov-commenter
Copy link

codecov-commenter commented Aug 11, 2022

Codecov Report

Merging #154 (06cf10d) into main (05d858a) will increase coverage by 0.13%.
The diff coverage is 87.93%.

@@            Coverage Diff             @@
##             main     #154      +/-   ##
==========================================
+ Coverage   54.00%   54.14%   +0.13%     
==========================================
  Files          89       89              
  Lines        7997     8027      +30     
==========================================
+ Hits         4319     4346      +27     
- Misses       3275     3278       +3     
  Partials      403      403              
Impacted Files Coverage Δ
banyand/tsdb/bucket/bucket.go 0.00% <0.00%> (ø)
banyand/tsdb/bucket/strategy.go 76.92% <90.32%> (+3.78%) ⬆️
banyand/tsdb/block.go 67.33% <100.00%> (+2.28%) ⬆️
banyand/tsdb/segment.go 65.33% <100.00%> (+0.41%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@hanahmily hanahmily merged commit 42c81ee into main Aug 11, 2022
@hanahmily hanahmily deleted the leak-tsdb branch August 11, 2022 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants