Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix data race #158

Merged
merged 1 commit into from
Aug 24, 2022
Merged

Fix data race #158

merged 1 commit into from
Aug 24, 2022

Conversation

hanahmily
Copy link
Contributor

Signed-off-by: Gao Hongtao hanahmily@gmail.com

Signed-off-by: Gao Hongtao <hanahmily@gmail.com>
@hanahmily hanahmily added the bug Something isn't working label Aug 24, 2022
@hanahmily hanahmily added this to the 0.2.0 milestone Aug 24, 2022
Copy link
Contributor

@lujiajing1126 lujiajing1126 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. But how could the data race happen? Block closed before goroutine start?

@hanahmily hanahmily merged commit bb433f4 into main Aug 24, 2022
@hanahmily hanahmily deleted the tsdb-race branch August 24, 2022 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
3 participants