Fix test cases with Eventually semantics #183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Megrez Lu <lujiajing1126@gmail.com>
hanahmily
reviewed
Oct 6, 2022
test/cases/measure/data/data.go
Outdated
| @@ -26,16 +26,16 @@ import ( | |||
| "time" | |||
|
|
|||
| "github.com/google/go-cmp/cmp" | |||
| g "github.com/onsi/ginkgo/v2" | |||
| gm "github.com/onsi/gomega" | |||
| . "github.com/onsi/ginkgo/v2" | |||
There was a problem hiding this comment.
ci might fails
Oh, I see the linter issues... Let me revert back this part
There was a problem hiding this comment.
But It seems we miss format for the test package?
There was a problem hiding this comment.
No. It doesn't ignore it. But we have to make the order deterministic.
Codecov Report
@@ Coverage Diff @@
## main #183 +/- ##
=======================================
Coverage 41.05% 41.05%
=======================================
Files 73 73
Lines 6835 6835
=======================================
Hits 2806 2806
Misses 3769 3769
Partials 260 260
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
hanahmily
approved these changes
Oct 7, 2022
hanahmily
pushed a commit
that referenced
this pull request
Oct 7, 2022
* fix test cases with Eventually semantics
hanahmily
pushed a commit
that referenced
this pull request
Oct 7, 2022
* fix test cases with Eventually semantics
hanahmily
pushed a commit
that referenced
this pull request
Oct 7, 2022
* fix test cases with Eventually semantics
wu-sheng
pushed a commit
that referenced
this pull request
Oct 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Megrez Lu lujiajing1126@gmail.com
This PR tends to fix test cases failures due to async write.
Before this PR, integration tests randomly failed.