Improve building system on Windows: #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Remove all generated files * Add repo level core.autocrlf * Tweak Makefile * Add Windows section to CONTRIBUTING.md Signed-off-by: Gao Hongtao <hanahmily@gmail.com>
hanahmily
added
documentation
Signed-off-by: Gao Hongtao <hanahmily@gmail.com>
|
I've verified it on Windows :) |
|
I have verified it on the window. |
wu-sheng
approved these changes
Oct 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes tend to make the building system work on Windows:
I dropped all proto-generated GO and swagger JSON files from the repo. These files are used to help developers build the binary without generating them. But their line endings vary on different platforms.
@WuChuSheng1 @sacloudy Would you please help me verify this by running
make pre-pushin the root folder?Signed-off-by: Gao Hongtao hanahmily@gmail.com