Drop desperate lint rule #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gao Hongtao <hanahmily@gmail.com>
Signed-off-by: Gao Hongtao <hanahmily@gmail.com>
Signed-off-by: Gao Hongtao <hanahmily@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #225 +/- ##
==========================================
+ Coverage 43.22% 43.75% +0.53%
==========================================
Files 87 88 +1
Lines 8949 9055 +106
==========================================
+ Hits 3868 3962 +94
- Misses 4709 4717 +8
- Partials 372 376 +4
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
wu-sheng
reviewed
Dec 5, 2022
| @@ -25,6 +25,7 @@ env: | |||
|
|
|||
| jobs: | |||
| test: | |||
| if: github.repository == 'apache/skywalking-banyandb' | |||
There was a problem hiding this comment.
Yes, tend to block PR to run this test.
wu-sheng
previously approved these changes
Dec 5, 2022
Signed-off-by: Gao Hongtao <hanahmily@gmail.com>
wu-sheng
approved these changes
Dec 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the desperate lint rule and dead codes.