Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: BanyanDB ui unable to load icon #298

Merged
merged 2 commits into from
Jul 9, 2023
Merged

Conversation

ButterBright
Copy link
Member

Fix apache/skywalking#11059

  • Add a unit test to verify that the fix works.
  • Explain briefly why the bug exists and how to fix it.

res

@lujiajing1126 lujiajing1126 added bug Something isn't working ui Webapp related labels Jul 8, 2023
@lujiajing1126 lujiajing1126 added this to the 0.5.0 milestone Jul 8, 2023
Copy link
Contributor

@lujiajing1126 lujiajing1126 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pls add changes

@codecov-commenter
Copy link

codecov-commenter commented Jul 8, 2023

Codecov Report

Merging #298 (6693ad7) into main (c1d3271) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #298   +/-   ##
=======================================
  Coverage   44.24%   44.24%           
=======================================
  Files          93       93           
  Lines        9811     9811           
=======================================
  Hits         4341     4341           
  Misses       5052     5052           
  Partials      418      418           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@lujiajing1126 lujiajing1126 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@lujiajing1126 lujiajing1126 merged commit df13bd6 into apache:main Jul 9, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ui Webapp related
Projects
None yet
3 participants