Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix timer not released #300

Merged
merged 2 commits into from
Jul 13, 2023
Merged

Fix timer not released #300

merged 2 commits into from
Jul 13, 2023

Conversation

hailin0
Copy link
Contributor

@hailin0 hailin0 commented Jul 12, 2023

Fix

  • Add a unit test to verify that the fix works.
  • Explain briefly why the bug exists and how to fix it.

@wu-sheng wu-sheng requested a review from hanahmily July 12, 2023 05:28
@wu-sheng wu-sheng added this to the 0.5.0 milestone Jul 12, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jul 12, 2023

Codecov Report

Merging #300 (d78730e) into main (df13bd6) will increase coverage by 0.00%.
The diff coverage is 66.66%.

@@           Coverage Diff           @@
##             main     #300   +/-   ##
=======================================
  Coverage   44.22%   44.23%           
=======================================
  Files          93       93           
  Lines        9811     9814    +3     
=======================================
+ Hits         4339     4341    +2     
- Misses       5054     5055    +1     
  Partials      418      418           
Impacted Files Coverage Δ
pkg/index/inverted/inverted.go 69.72% <66.66%> (-0.03%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@hanahmily hanahmily merged commit aee9148 into apache:main Jul 13, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants