Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multiple roles for banyand #305

Merged
merged 3 commits into from
Jul 26, 2023
Merged

Support multiple roles for banyand #305

merged 3 commits into from
Jul 26, 2023

Conversation

hanahmily
Copy link
Contributor

Banyand has been updated to run in multiple roles, but it cannot work in cluster mode. There are still several pending tasks to be completed.

As a reviewer, you should focus on the document that outlines the fundamental behavior of the server with multiple roles in Banyand.

Signed-off-by: Gao Hongtao <hanahmily@gmail.com>
@hanahmily hanahmily added documentation Improvements or additions to documentation enhancement New feature or request labels Jul 19, 2023
@hanahmily hanahmily added this to the 0.5.0 milestone Jul 19, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #305 (595c6a0) into main (c001e15) will decrease coverage by 0.09%.
The diff coverage is 4.00%.

@@            Coverage Diff             @@
##             main     #305      +/-   ##
==========================================
- Coverage   39.93%   39.84%   -0.09%     
==========================================
  Files         100      101       +1     
  Lines       10870    10894      +24     
==========================================
  Hits         4341     4341              
- Misses       6111     6135      +24     
  Partials      418      418              
Impacted Files Coverage Δ
banyand/liaison/grpc/property.go 0.00% <ø> (ø)
banyand/liaison/grpc/registry.go 20.13% <ø> (ø)
banyand/metadata/client.go 0.00% <0.00%> (ø)
pkg/run/run.go 0.00% <0.00%> (ø)
banyand/liaison/grpc/server.go 68.47% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Signed-off-by: Gao Hongtao <hanahmily@gmail.com>
// under the License.

// Package embeddedetcd implements an embedded etcd server.
package embeddedetcd
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lujiajing1126 I've already separated the embed server from the schema registry. Could you update your local repo in case there are some conflicts?

@wu-sheng
Copy link
Member

So, with this spliting, banyandb still is able to run in stand alone mode? But as support to set an external etcd cluster?

@hanahmily hanahmily merged commit 42c10e6 into main Jul 26, 2023
13 checks passed
@hanahmily hanahmily deleted the cluster branch July 26, 2023 03:59
@hanahmily
Copy link
Contributor Author

So, with this spliting, banyandb still is able to run in stand alone mode? But as support to set an external etcd cluster?

It has the capacity to run as a standalone with embed etcd without external ones.

@wu-sheng
Copy link
Member

I mean, do we expect am external etcd in cluster? Or still running internally?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
5 participants