Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop discovery module #311

Merged
merged 1 commit into from
Aug 2, 2023
Merged

Drop discovery module #311

merged 1 commit into from
Aug 2, 2023

Conversation

hanahmily
Copy link
Contributor

As per the discussion last month, the core contributors have decided to remove the "discovery" module that serves as the discovery service function. Instead, the "metadata" module will now take on this role by providing the cluster's topology of nodes and shards.

@lujiajing1126 This change concentrates on the interface of "metadata", I need the added operations to support other feats. The internal implementation is left to you as we discussed before.

Signed-off-by: Gao Hongtao <hanahmily@gmail.com>
@hanahmily hanahmily added the enhancement New feature or request label Aug 2, 2023
@hanahmily hanahmily added this to the 0.5.0 milestone Aug 2, 2023
@hanahmily hanahmily added the chore label Aug 2, 2023
@codecov-commenter
Copy link

codecov-commenter commented Aug 2, 2023

Codecov Report

Merging #311 (c735498) into main (397d6d8) will decrease coverage by 0.18%.
The diff coverage is 37.08%.

@@            Coverage Diff             @@
##             main     #311      +/-   ##
==========================================
- Coverage   39.82%   39.64%   -0.18%     
==========================================
  Files         101      104       +3     
  Lines       10894    11101     +207     
==========================================
+ Hits         4338     4401      +63     
- Misses       6131     6266     +135     
- Partials      425      434       +9     
Files Changed Coverage Δ
banyand/measure/measure.go 80.00% <ø> (-0.89%) ⬇️
banyand/measure/metadata.go 49.19% <ø> (-0.61%) ⬇️
banyand/metadata/schema/checker.go 33.33% <0.00%> (-8.49%) ⬇️
banyand/metadata/schema/node.go 0.00% <0.00%> (ø)
banyand/metadata/schema/schema.go 36.47% <0.00%> (-11.97%) ⬇️
banyand/metadata/schema/shard.go 0.00% <0.00%> (ø)
banyand/stream/metadata.go 53.24% <ø> (-0.90%) ⬇️
banyand/stream/stream.go 76.47% <ø> (-1.91%) ⬇️
banyand/liaison/grpc/discovery.go 37.98% <41.21%> (+27.67%) ⬆️
banyand/metadata/client.go 35.83% <50.00%> (+1.62%) ⬆️
... and 4 more

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@wu-sheng wu-sheng merged commit a955dad into main Aug 2, 2023
13 checks passed
@wu-sheng wu-sheng deleted the drop-discovery branch August 2, 2023 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore enhancement New feature or request
Projects
None yet
3 participants