Add file system vector-IO operations interface. #312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #312 +/- ##
=======================================
Coverage 39.74% 39.74%
=======================================
Files 105 105
Lines 11230 11230
=======================================
Hits 4463 4463
Misses 6320 6320
Partials 447 447 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
hanahmily
requested changes
Aug 7, 2023
hanahmily
reviewed
Aug 7, 2023
hanahmily
previously approved these changes
Aug 8, 2023
wu-sheng
reviewed
Aug 8, 2023
| @@ -112,7 +112,7 @@ return: File pointer, you can use it for various operations. | |||
|
|
|||
| ### Write | |||
| BanyanDB provides two methods for writing files. | |||
| Append mode, which adds new data to the end of a file. This mode is typically used for WAL. | |||
| Append mode, which adds new data to the end of a file. This mode is typically used for WAL. And BanyanDB supports vector Append mode, which supports appending consecutive buffers to the end of the file. | |||
There was a problem hiding this comment.
Is the A of Append uppercase on purpose? This seems strange.
There was a problem hiding this comment.
Capitalize just because it's the first letter. So, what should the specification be？
|
I can't see where we link to |
We have not implemented it. As WAL, once the implementation gets merged, we would publish this doc. |
hanahmily
approved these changes
Aug 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add file system Vector-IO operations interface.