Implement node role registration

[hanahmily]

Register the node role to the metadata registry.

There are two categories of nodes:

• Stateful nodes: standalone, data nodes, and mixed storage nodes. Their node id has to be passed through a flag "data-node-id", which is unique and sortable between each other.
• Stateless nodes: Liaison, query nodes. Their node id is generated by the metadata module automatically.

• If this pull request closes/resolves/fixes an existing issue, replace the issue number. Fixes [Feature] [Cluster] Node roles and discovery skywalking#10895.
• Update the CHANGES log.

[codecov-commenter]

Codecov Report

Merging #314 (23072bc) into main (18e3903) will increase coverage by 0.00%.
The diff coverage is 45.21%.

@@           Coverage Diff            @@
##             main     #314    +/-   ##
========================================
  Coverage   39.74%   39.74%            
========================================
  Files         105      105            
  Lines       11230    11337   +107     
========================================
+ Hits         4463     4506    +43     
- Misses       6320     6373    +53     
- Partials      447      458    +11     

Files Changed	Coverage Δ
banyand/metadata/schema/checker.go	33.82% <0.00%> (+0.49%)	⬆️
pkg/run/run.go	0.00% <0.00%> (ø)
test/stress/cases/istio/repo.go	0.00% <0.00%> (ø)
banyand/metadata/schema/node.go	7.14% <11.11%> (+7.14%)	⬆️
banyand/measure/metadata.go	49.19% <50.00%> (ø)
banyand/metadata/server.go	48.93% <50.00%> (-2.18%)	⬇️
banyand/metadata/schema/etcd.go	57.14% <50.98%> (-1.34%)	⬇️
banyand/metadata/client.go	38.46% <54.16%> (+2.62%)	⬆️
banyand/liaison/grpc/server.go	66.86% <63.63%> (-0.01%)	⬇️
banyand/measure/service.go	74.75% <87.50%> (+0.49%)	⬆️
... and 4 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[wu-sheng]

Does this mean, nodes could be deployed on different roles now? If so, I think the installation doc could be updated.

https://skywalking.apache.org/docs/skywalking-banyandb/next/installation/

One is current standalone mode, the other should start from cluster mode deployment.

[hanahmily]

Does this mean, nodes could be deployed on different roles now? If so, I think the installation doc could be updated.

https://skywalking.apache.org/docs/skywalking-banyandb/next/installation/

One is current standalone mode, the other should start from cluster mode deployment.

Previous commits have already drafted the role-based deployment.

https://github.com/apache/skywalking-banyandb/pull/314/files#diff-8b042e3f94ca5c59a7cd990b950aec0073ea84fe811e7b22be51158d7b180d56 amend more introduced in this change.

[wu-sheng]

I can see the node ID is unique, and considering our query is applying to all data node, why the node IDs are not auto generated?
What is the point to keep manually setting?

[hanahmily]

I can see the node ID is unique, and considering our query is applying to all data node, why the node IDs are not auto generated? What is the point to keep manually setting?

It is important for the data node id to be stateful because the shard allocation algorithm depends on it. This means that the node id should be either obtained from a flag or configuration, or generated initially and then stored locally. The first is easier and ensures straightforward maintenance and storage.

[hanahmily]

I can see the node ID is unique, and considering our query is applying to all data node, why the node IDs are not auto generated? What is the point to keep manually setting?

It is important for the data node id to be stateful because the shard allocation algorithm depends on it. This means that the node id should be either obtained from a flag or configuration, or generated initially and then stored locally. The first is easier and ensures straightforward maintenance and storage.

Some databases can use the hostname as the node id, Would we prefer this pattern?

[wu-sheng]

We just had a discussion. The node list should be removed, and no need to add node ID manually.
The data node and shard assignment should be done automatically, as our query solution is there and aggressively querying all nodes.

Further, etcd server is only recommended in a separate deployment. The bundled etcd should be for standalone only officially.