Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement the remote queue to spreading data to data nodes #320

Merged
merged 1 commit into from
Aug 28, 2023
Merged

Conversation

hanahmily
Copy link
Contributor

@hanahmily hanahmily added the enhancement New feature or request label Aug 28, 2023
@hanahmily hanahmily added this to the 0.5.0 milestone Aug 28, 2023
@@ -101,7 +101,7 @@ func (s *streamService) Write(stream streamv1.StreamService_WriteServer) error {
if s.log.Debug().Enabled() {
iwr.EntityValues = tagValues.Encode()
}
message := bus.NewMessage(bus.MessageID(time.Now().UnixNano()), iwr)
message := bus.NewMessageWithNode(bus.MessageID(time.Now().UnixNano()), "TODO", iwr)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lujiajing1126 The result of shard allocation will be passed with the message.

Signed-off-by: Gao Hongtao <hanahmily@gmail.com>
@codecov-commenter
Copy link

codecov-commenter commented Aug 28, 2023

Codecov Report

Merging #320 (3ea3b64) into main (3e589ab) will decrease coverage by 0.04%.
The diff coverage is 34.61%.

@@            Coverage Diff             @@
##             main     #320      +/-   ##
==========================================
- Coverage   40.86%   40.83%   -0.04%     
==========================================
  Files         107      107              
  Lines       11376    11391      +15     
==========================================
+ Hits         4649     4651       +2     
- Misses       6258     6271      +13     
  Partials      469      469              
Files Changed Coverage Δ
banyand/liaison/grpc/measure.go 2.02% <0.00%> (-0.07%) ⬇️
banyand/liaison/grpc/stream.go 2.38% <0.00%> (-0.06%) ⬇️
pkg/bus/bus.go 69.56% <11.11%> (-5.21%) ⬇️
banyand/liaison/grpc/discovery.go 40.86% <100.00%> (ø)
banyand/liaison/grpc/server.go 66.86% <100.00%> (ø)
banyand/measure/service.go 89.83% <100.00%> (+0.35%) ⬆️
banyand/stream/service.go 78.57% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@hanahmily hanahmily merged commit 8ee20fd into main Aug 28, 2023
13 checks passed
@hanahmily hanahmily deleted the queue branch August 28, 2023 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
3 participants