Refactor distributed query #321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gao Hongtao <hanahmily@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #321 +/- ##
=======================================
Coverage 40.83% 40.83%
=======================================
Files 107 107
Lines 11391 11391
=======================================
Hits 4651 4651
Misses 6271 6271
Partials 469 469 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
hailin0
reviewed
Aug 31, 2023
|
LGTM |
hailin0
approved these changes
Aug 31, 2023
|
So, Liaison is a query node now? There is no separate query node. |
Exactly. There are two main roles in a cluster mode. |
wu-sheng
approved these changes
Aug 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new design merges liaison and query nodes to provide a more flexible and simple architecture.