Add mod revision check to write requests(measure/stream) #322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hailin0
force-pushed
the
add_mod_revision
branch
from
b5a4104
to
935b111
Compare
hailin0
force-pushed
the
add_mod_revision
branch
2 times, most recently
from
d2a163e
to
12fd875
Compare
Codecov Report
@@ Coverage Diff @@
## main #322 +/- ##
==========================================
- Coverage 40.63% 40.59% -0.05%
==========================================
Files 110 110
Lines 11726 11775 +49
==========================================
+ Hits 4765 4780 +15
- Misses 6493 6526 +33
- Partials 468 469 +1
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
hailin0
commented
Sep 8, 2023
| @@ -33,7 +33,7 @@ services: | |||
| - sw_agent:/skywalking-java-agent | |||
|
|
|||
| oap: | |||
| image: "ghcr.io/apache/skywalking/oap:${SW_OAP_COMMIT}" | |||
| image: "ghcr.io/apache/skywalking-banyandb-java-client/oap:${SW_OAP_COMMIT}" | |||
There was a problem hiding this comment.
Use this image for integration testing
|
show case 2023-09-11+00.47.28_out.mov |
hailin0
force-pushed
the
add_mod_revision
branch
from
654ea1c
to
80ef1d3
Compare
hailin0
commented
Sep 11, 2023
pkg/query/logical/common.go
Outdated
| "the number of tags %d in %s is less then expected %d", | ||
| len(parsedTagFamily.Tags), familyName, len(refs)) | ||
| } | ||
| tags := make([]*modelv1.Tag, len(parsedTagFamily.GetTags())) |
There was a problem hiding this comment.
Fix query failure caused by schema changes
hailin0
force-pushed
the
add_mod_revision
branch
2 times, most recently
from
1a6baeb
to
8d55363
Compare
- Support for create/update schema check mod revision - Support for write data check mod revision - Adapt to web console requests - Update OAP e2e image - Fix query failure caused by schema change
hailin0
force-pushed
the
add_mod_revision
branch
from
8d55363
to
601615d
Compare
|
PTAL |
hanahmily
requested changes
Sep 13, 2023
hanahmily
requested changes
Sep 14, 2023
hanahmily
approved these changes
Sep 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If this is non-trivial feature, paste the links/URLs to the design doc.
Update the documentation to include this new feature.
Tests(including UT, IT, E2E) are added to verify the new feature.
If it's UI related, attach the screenshots below.
If this pull request closes/resolves/fixes an existing issue, replace the issue number. Close Add mod revision check to write requests skywalking#10956.
Update the
CHANGESlog.