New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix parse environment variables error #323

Merged

hanahmily merged 2 commits into apache:main from ButterBright:main

Sep 4, 2023

Member

ButterBright commented Sep 4, 2023

Fix parse environment variables error

The flags passed through the command line are connected by hyphens instead of dots.

Add a unit test to verify that the fix works.
Explain briefly why the bug exists and how to fix it.

If this pull request closes/resolves/fixes an existing issue, replace the issue number. Fixes apache/skywalking#.
Update the CHANGES log.

ButterBright added 2 commits

September 4, 2023 22:42


          fix: parse environment variables error

a41cabd


          Update CHANGES.md

a044fb0

wu-sheng added this to the 0.5.0 milestone

wu-sheng requested a review from hanahmily

September 4, 2023 15:01

wu-sheng added the bug label

hanahmily approved these changes

View reviewed changes

hanahmily merged commit 589cfb0 into apache:main

13 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment