Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TTL to the property #332

Merged
merged 5 commits into from
Sep 17, 2023
Merged

Add TTL to the property #332

merged 5 commits into from
Sep 17, 2023

Conversation

hanahmily
Copy link
Contributor

@hanahmily hanahmily added this to the 0.5.0 milestone Sep 17, 2023
@wu-sheng wu-sheng added the enhancement New feature or request label Sep 17, 2023
@codecov-commenter
Copy link

codecov-commenter commented Sep 17, 2023

Codecov Report

Merging #332 (0ab1d62) into main (8996af5) will decrease coverage by 0.33%.
The diff coverage is 9.30%.

@@            Coverage Diff             @@
##             main     #332      +/-   ##
==========================================
- Coverage   40.57%   40.25%   -0.33%     
==========================================
  Files         110      110              
  Lines       11775    11915     +140     
==========================================
+ Hits         4778     4796      +18     
- Misses       6528     6650     +122     
  Partials      469      469              
Files Changed Coverage Δ
banyand/liaison/grpc/property.go 0.00% <0.00%> (ø)
banyand/metadata/schema/property.go 0.00% <0.00%> (ø)
banyand/metadata/schema/schema.go 58.82% <ø> (ø)
bydbctl/internal/cmd/rest.go 52.31% <ø> (ø)
bydbctl/internal/cmd/property.go 89.53% <83.33%> (-1.77%) ⬇️
banyand/metadata/allocator.go 84.84% <100.00%> (+10.56%) ⬆️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Signed-off-by: Gao Hongtao <hanahmily@gmail.com>
Signed-off-by: Gao Hongtao <hanahmily@gmail.com>
Signed-off-by: Gao Hongtao <hanahmily@gmail.com>
Signed-off-by: Gao Hongtao <hanahmily@gmail.com>
docs/crud/property.md Outdated Show resolved Hide resolved
Signed-off-by: Gao Hongtao <hanahmily@gmail.com>
@wu-sheng wu-sheng merged commit f3abf75 into main Sep 17, 2023
13 checks passed
@wu-sheng wu-sheng deleted the property-ttl branch September 17, 2023 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
3 participants