Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add node selector to support topology calculation #334

Merged
merged 7 commits into from
Oct 9, 2023
Merged

Conversation

lujiajing1126
Copy link
Contributor

@lujiajing1126 lujiajing1126 commented Sep 20, 2023

A continuation of #324

@lujiajing1126 lujiajing1126 added the enhancement New feature or request label Sep 20, 2023
@lujiajing1126 lujiajing1126 added this to the 0.5.0 milestone Sep 20, 2023
@lujiajing1126 lujiajing1126 self-assigned this Sep 20, 2023
@codecov-commenter
Copy link

codecov-commenter commented Sep 20, 2023

Codecov Report

Merging #334 (7322d23) into main (63be6e8) will increase coverage by 0.04%.
The diff coverage is 25.97%.

@@            Coverage Diff             @@
##             main     #334      +/-   ##
==========================================
+ Coverage   39.83%   39.87%   +0.04%     
==========================================
  Files         109      111       +2     
  Lines       11883    11938      +55     
==========================================
+ Hits         4733     4760      +27     
- Misses       6683     6709      +26     
- Partials      467      469       +2     
Files Coverage Δ
pkg/node/maglev.go 64.28% <64.28%> (ø)
banyand/liaison/grpc/node.go 35.89% <42.85%> (+30.89%) ⬆️
pkg/node/interface.go 4.76% <4.76%> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@hanahmily hanahmily left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The codes look good to me roughly, but additional test cases are necessary before merging.

pkg/node/maglev_test.go Show resolved Hide resolved
@hanahmily hanahmily merged commit 2cf42aa into main Oct 9, 2023
14 checks passed
@hanahmily hanahmily deleted the node-selector branch October 9, 2023 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
3 participants