-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add node selector to support topology calculation #334
Conversation
Codecov Report
@@ Coverage Diff @@
## main #334 +/- ##
==========================================
+ Coverage 39.83% 39.87% +0.04%
==========================================
Files 109 111 +2
Lines 11883 11938 +55
==========================================
+ Hits 4733 4760 +27
- Misses 6683 6709 +26
- Partials 467 469 +2
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The codes look good to me roughly, but additional test cases are necessary before merging.
CHANGES
log.A continuation of #324