Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shard-level buffer #339

Merged
merged 2 commits into from
Oct 10, 2023
Merged

Shard-level buffer #339

merged 2 commits into from
Oct 10, 2023

Conversation

hanahmily
Copy link
Contributor

These changes improve how the buffer uses memory.

Fix

  • Add a unit test to verify that the fix works.
  • Update the CHANGES log.

Unified the buffers separated in blocks to a single buffer
in the shard

Signed-off-by: Gao Hongtao <hanahmily@gmail.com>
@hanahmily hanahmily added the enhancement New feature or request label Oct 10, 2023
@hanahmily hanahmily added this to the 0.5.0 milestone Oct 10, 2023
@codecov-commenter
Copy link

codecov-commenter commented Oct 10, 2023

Codecov Report

Merging #339 (4b9ad81) into main (2cf42aa) will decrease coverage by 0.53%.
Report is 1 commits behind head on main.
The diff coverage is 58.18%.

@@            Coverage Diff             @@
##             main     #339      +/-   ##
==========================================
- Coverage   39.87%   39.34%   -0.53%     
==========================================
  Files         111      112       +1     
  Lines       11938    12298     +360     
==========================================
+ Hits         4760     4839      +79     
- Misses       6709     6983     +274     
- Partials      469      476       +7     
Files Coverage Δ
banyand/tsdb/shard.go 57.07% <100.00%> (+0.66%) ⬆️
banyand/tsdb/tsdb.go 53.93% <100.00%> (+0.56%) ⬆️
banyand/tsdb/block.go 50.91% <50.00%> (-0.21%) ⬇️
banyand/kv/kv.go 0.00% <0.00%> (ø)
banyand/kv/badger.go 8.90% <65.38%> (ø)
banyand/stream/tstable.go 0.00% <0.00%> (ø)
banyand/measure/tstable.go 0.00% <0.00%> (ø)
banyand/tsdb/buffer.go 68.99% <67.77%> (+0.42%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@wu-sheng wu-sheng merged commit 768baa1 into main Oct 10, 2023
14 checks passed
@wu-sheng wu-sheng deleted the buffer branch October 10, 2023 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
3 participants