Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added unit test for hash.go in convert package #393

Merged
merged 1 commit into from
Mar 1, 2024

Conversation

sivasathyaseeelan
Copy link
Contributor

Fix

This PR adds unit test for hash.go in convert package and partially fixes apache/skywalking#11942

  • Add a unit test to verify that the fix works.
  • Explain briefly why the bug exists and how to fix it.

Signed-off-by: sivasathyaseeelan <dnsiva.sathyaseelan.chy21@iitbhu.ac.in>
@wu-sheng wu-sheng added this to the 0.6.0 milestone Feb 29, 2024
@codecov-commenter
Copy link

codecov-commenter commented Feb 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.16%. Comparing base (fb543e7) to head (8d22ab9).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #393      +/-   ##
==========================================
+ Coverage   48.13%   48.16%   +0.03%     
==========================================
  Files         173      173              
  Lines       21500    21500              
==========================================
+ Hits        10348    10355       +7     
+ Misses      10285    10278       -7     
  Partials      867      867              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hanahmily hanahmily merged commit 2e2fc88 into apache:main Mar 1, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants