Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed name of children route used for default/notfound route #411

Merged
merged 2 commits into from
Mar 14, 2024

Conversation

sksDonni
Copy link
Contributor

Fix apache/skywalking#12007
Properties page not loading up

  • Add a unit test to verify that the fix works.

  • Explain briefly why the bug exists and how to fix it.
    The issue was caused due to the use of property keyword in the name parameter of route used for not found pages.

  • If this is non-trivial feature, paste the links/URLs to the design doc.

  • Update the documentation to include this new feature.

  • Tests(including UT, IT, E2E) are added to verify the new feature.

  • If it's UI related, attach the screenshots below.

Screen.Recording.2024-03-14.at.2.22.12.AM.mov

@sksDonni
Copy link
Contributor Author

@hanahmily @wu-sheng @sivasathyaseeelan Can you please review the change.

@wu-sheng wu-sheng added the bug Something isn't working label Mar 14, 2024
@wu-sheng wu-sheng added this to the 0.6.0 milestone Mar 14, 2024
@wu-sheng wu-sheng requested a review from hanahmily March 14, 2024 00:32
@codecov-commenter
Copy link

codecov-commenter commented Mar 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.77%. Comparing base (965ac21) to head (c3149ff).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #411      +/-   ##
==========================================
- Coverage   47.79%   47.77%   -0.02%     
==========================================
  Files         173      173              
  Lines       21562    21562              
==========================================
- Hits        10306    10302       -4     
- Misses      10382    10385       +3     
- Partials      874      875       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hanahmily hanahmily merged commit 2f848ef into apache:main Mar 14, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
4 participants