Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Measure IndexRule and IndexRuleBinding to Measure Page #418

Merged

Conversation

Sylvie-Wxr
Copy link
Contributor

@Sylvie-Wxr Sylvie-Wxr commented Mar 16, 2024

Feature demo

  1. Read IndexRule and IndexRuleBinding
read.mp4
  1. Create IndexRule and IndexRuleBinding
create.mp4
  1. Edit IndexRule and IndexRuleBinding
edit.mp4
  1. Delete IndexRule and IndexRuleBinding
delete.mp4

Implementation Explannation

  1. Add new routers to measure page
  2. Add schema (measure or stream) to router and router.params to differentiate
  3. Edit UI components to allow Read/Edit/View/Delete

@wu-sheng wu-sheng requested review from hanahmily and nacx and removed request for nacx March 16, 2024 07:09
@wu-sheng wu-sheng added this to the 0.6.0 milestone Mar 16, 2024
@wu-sheng wu-sheng added the ui Webapp related label Mar 16, 2024
@wu-sheng
Copy link
Member

Please link to the original issue, thanks.

@codecov-commenter
Copy link

codecov-commenter commented Mar 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.73%. Comparing base (12c4270) to head (876c796).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #418      +/-   ##
==========================================
- Coverage   47.76%   47.73%   -0.03%     
==========================================
  Files         173      173              
  Lines       21586    21586              
==========================================
- Hits        10310    10305       -5     
- Misses      10403    10407       +4     
- Partials      873      874       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wu-sheng wu-sheng requested a review from Fine0830 March 16, 2024 11:47
Copy link
Contributor

@hanahmily hanahmily left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wu-sheng wu-sheng merged commit 0da162e into apache:main Mar 16, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ui Webapp related
Projects
None yet
4 participants