Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: default route #354

Merged
merged 3 commits into from
Dec 26, 2023
Merged

feat: default route #354

merged 3 commits into from
Dec 26, 2023

Conversation

heyanlong
Copy link
Member

If all menus are not active, the marketplace is used

@wu-sheng
Copy link
Member

What do you mean the marketplace is used?

@wu-sheng wu-sheng added the enhancement New feature or request label Dec 26, 2023
@wu-sheng wu-sheng added this to the 10.0.0 milestone Dec 26, 2023
@heyanlong
Copy link
Member Author

Because marketplace routing always exists in the left menu
image

@wu-sheng
Copy link
Member

Oh, you mean if none service exists, no marketplace menu, right?
This should be a bug.

@wu-sheng wu-sheng added bug Something isn't working and removed enhancement New feature or request labels Dec 26, 2023
@heyanlong
Copy link
Member Author

Oh, you mean if none service exists, no marketplace menu, right? This should be a bug.

No, there is no service, and it jumps to the service menu by default. So if no service exists, jumps to marketplace.

wu-sheng
wu-sheng previously approved these changes Dec 26, 2023
Copy link
Member

@wu-sheng wu-sheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good for idea. Let's wait for @Fine0830 for codes review.

src/router/index.ts Outdated Show resolved Hide resolved
src/router/index.ts Outdated Show resolved Hide resolved
@Fine0830 Fine0830 merged commit c5d80d9 into apache:main Dec 26, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
3 participants