feat: add isDefault to the dashboard configuration
#355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could we rename top level to default dashboard? Top level seems not a clear name. |
Sure. |
Fine0830
changed the title
topLevel to the dashboard configurationisDefault to the dashboard configuration
|
Updated 
|
wu-sheng
approved these changes
Jan 3, 2024
|
fyi @wankai123 We could test this for virtual services. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
isDefaultto the dashboard configuration, since the nodes and calls of service hierarchy topology need default dashboards to click to jump.Screenshot
Signed-off-by: QIuxia Fan qiuxiafan@apache.org