Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(doc): fix the dev local port #375

Merged
merged 1 commit into from
Mar 12, 2024
Merged

Conversation

CzyerChen
Copy link
Contributor

The default UI address is http://localhost:3000.

  VITE v4.5.2  ready in 2551 ms

  ➜  Local:   http://localhost:3000/

Comment on lines -40 to +45
* Mail list: **dev@skywalking.apache.org**. Mail to `dev-subscribe@skywalking.apache.org`, follow the reply to subscribe to the mail list.
* Send `Request to join SkyWalking slack` mail to the mail list(`dev@skywalking.apache.org`), we will invite you in.
* For Chinese speaker, send `[CN] Request to join SkyWalking slack` mail to the mail list(`dev@skywalking.apache.org`), we will invite you in.
* Twitter, [ASFSkyWalking](https://twitter.com/AsfSkyWalking)
* [bilibili B站 视频](https://space.bilibili.com/390683219)

- Mail list: **dev@skywalking.apache.org**. Mail to `dev-subscribe@skywalking.apache.org`, follow the reply to subscribe to the mail list.
- Send `Request to join SkyWalking slack` mail to the mail list(`dev@skywalking.apache.org`), we will invite you in.
- For Chinese speaker, send `[CN] Request to join SkyWalking slack` mail to the mail list(`dev@skywalking.apache.org`), we will invite you in.
- Twitter, [ASFSkyWalking](https://twitter.com/AsfSkyWalking)
- [bilibili B 站 视频](https://space.bilibili.com/390683219)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't reformat irrelevant codes.

@@ -34,14 +34,15 @@ npm install
npm run dev
```

The default UI address is `http://localhost:8080`.
The default UI address is `http://localhost:3000`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Fine0830 Please confirm. Should we get this on 8080 to align with webspp deployment mode.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's okay that the port is 3000 in dev mode.

@wu-sheng wu-sheng added this to the 10.0.0 milestone Mar 12, 2024
@wu-sheng wu-sheng requested a review from Fine0830 March 12, 2024 09:21
@wu-sheng
Copy link
Member

@CzyerChen Please revert irrelevant parts, the doc fix is good.

@CzyerChen
Copy link
Contributor Author

@CzyerChen Please revert irrelevant parts, the doc fix is good.

reformatted by prettier --write automatically when committing, and can not revert.

image

@wu-sheng wu-sheng merged commit 0e0b4e1 into apache:main Mar 12, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants