-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Enhancement] Add configure detection #13
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I’m not sure whether we should log warning messages when the config file is absent, because it’s completely optional and is just for reusing options in command line, when the users want to just run one or two commands for a quick look with all options given in command line, the warning message breaks the output json format and forces the users to create a configuration file there, WDYT @wu-sheng
We can send these warning logs to |
I think log into a file is not suitable for CLI. Recommend debug log, whicb we have an optional to open it. |
This is a not issue for CLI, just helps for debuging cli itself or user env, right? |
Codecov Report
@@ Coverage Diff @@
## master #13 +/- ##
=======================================
Coverage 64.28% 64.28%
=======================================
Files 5 5
Lines 84 84
=======================================
Hits 54 54
Misses 24 24
Partials 6 6 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merging
Add configure detection, if it does not exist, automatically skip loading.
If open ~/.skywalking.yml no such file, output warning and skip the file