Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trim leading and trailing newlines before rewrite license header cotent #94

Merged
merged 7 commits into from Mar 11, 2022

Conversation

tisonkun
Copy link
Member

This closes apache/skywalking#8529.

Also, rewrite all our files after the fix and a new content aligned template.

This is related to apache/skywalking#8657.

cc @wu-sheng @kezhenxu94

Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
pkg/header/fix.go Outdated Show resolved Hide resolved
Copy link
Member

@kezhenxu94 kezhenxu94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kezhenxu94 kezhenxu94 added this to the 0.3.0 milestone Mar 11, 2022
@kezhenxu94 kezhenxu94 added the bug Something isn't working label Mar 11, 2022
@kezhenxu94 kezhenxu94 merged commit f23c9f4 into apache:main Mar 11, 2022
@tisonkun tisonkun deleted the issue-8529 branch March 11, 2022 03:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants