fix lost trace when multi middleware handlerFunc #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Let's wait for project lead back from vacation. It should be next Monday. |
mrproliu
reviewed
Feb 5, 2024
|
|
||
| func isFirstHandle(c interface{}) bool { | ||
| if context, ok := c.(*nativeContext); ok { | ||
| return context.index < 0 |
There was a problem hiding this comment.
Following your diagram in the comment, I think It should equal zero? Please correct me if am wrong.
There was a problem hiding this comment.
In fact, the index is the index of HandlersChain, it is reset to -1 at the beginning of each request, and then incremented and executes the handlers[index] in the #Next().
func (c *Context) Next() {
c.index++
for c.index < int8(len(c.handlers)) {
c.handlers[c.index](c)
c.index++
}
}
There was a problem hiding this comment.
Then, could you help to add a comment to explain this mechanism in the code?
|
Please update the CHANGES.md, thanks. |
mrproliu
reviewed
Feb 6, 2024
mrproliu
approved these changes
Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
using the index of
[]HandlerFunc, determine if the current is the first HandlerFunc, and then handle the enhancement#11852