-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: hybird compilation issue on windows #179
Conversation
Signed-off-by: ShyunnY <1147212064@qq.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Could you please also update the CHANGES.md. Also, would you help to add a new plugin test in GHA for testing whether the go agent works on the windows or not?
Do we have a Windows to verify? |
I will write e2e tests :) |
7f8562a
to
f37eaef
Compare
Will you write in this PR or a new one? @ShyunnY |
Since it may be a while before I can write the e2e tests, I thought I'd start this work in a new PR. |
If CI can't be added here, we need a manul test. @mrproliu |
Could you help to add some screenshot in here? @ShyunnY |
cc @wu-sheng Hello! When I was fixing issue-12068, I found that go-agent had other problems, which made it impossible to carry out hybrid compilation under the windows platform. IMO, I think we should merge this PR first, and I will submit a new PR to solve the issue-12097 problem in the future. By the way, E2E testing should be carried out after we fix all issues. :) |
To be honest, as you are fixing Windows compiling, the new resolved issue should be fixed as well. And this PR has CI pipeline failing, which can't be merged by anyone, and doesn't fit SkyWalking traditions. |
You could use one PR to fix two issues, which is fine. |
Sorry, since this is my first time participating in a Thanks for your reply, I will work on this as soon as possible. |
One can add windows Github action to the .github workflows, just I'm not sure if our e2e pipeline can work on windows. |
I don't think e2e tool works. But at least, we could have compiling passed on Windows CI. |
Signed-off-by: ShyunnY <1147212064@qq.com>
f37eaef
to
95c276a
Compare
8e0a769
to
1ebd70d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I can't see Windows platform CI compiling. |
Could you upload some screenshots here? @ShyunnY |
@ShyunnY basic finished the compile phase on windows, but the tracing data not reported for now, he is working on it. |
Follow the steps of docs. We expect it to execute normally under windows. Project binaries successfully compile |
Fix