Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pprof port export in satellite #117

Merged
merged 3 commits into from
Apr 10, 2023
Merged

Add pprof port export in satellite #117

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
24c6c40
Add `pprof` port export in satellite
mrproliu Apr 10, 2023
3b9be9e
disable the pprof by default
mrproliu Apr 10, 2023
04b3162
update format
mrproliu Apr 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ Release Notes.
------------------

- Add helm chart for swck v0.7.0.
- Add `pprof` port export in satellite.

4.4.0
------------------
Expand Down
1 change: 1 addition & 0 deletions chart/skywalking/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -451,6 +451,7 @@ satellite:
ports:
grpc: 11800
prometheus: 1234
pprof: 6060
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to enable this by default? This is for debugging no?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it can be added for observing and querying execution status. If you think it's not necessary to turn it on, I can close this PR.

service:
type: ClusterIP
antiAffinity: "soft"
Expand Down