Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Elasticsearch chart dependency to 8.5.1 #97

Closed
wants to merge 1 commit into from

Conversation

zalintyre
Copy link
Contributor

The old version uses an outdated apiVersion for kind: PodDisruptionBudget, which breaks this chart for Kubernetes 1.21 and ongoing.

The following error emerges when using the old Elastic Helm chart:

Error: UPGRADE FAILED: resource mapping not found for name: "elasticsearch-master-pdb" namespace: "" from "": no matches for kind "PodDisruptionBudget" in version "policy/v1beta1"

As you can see, the newer version of the Elastic Helm chart uses some logic to pass the correct apiVersion: https://github.com/elastic/helm-charts/blob/v8.5.1/elasticsearch/templates/poddisruptionbudget.yaml

Kind regards
Franz

The old version uses an outdated apiVersion for kind: PodDisruptionBudget, which breaks this chart for Kubernetes 1.21 and ongoing.
@wu-sheng
Copy link
Member

Hi, ElasticSearch 8.5.1 is not licensed by the Apache 2.0 anymore. That is why we hold the upgrade.
We expose to connect existing ElasticSearch as you could use any installed version.

@kezhenxu94
Copy link
Member

It also breaks the CI

@kezhenxu94
Copy link
Member

Hi, ElasticSearch 8.5.1 is not licensed by the Apache 2.0 anymore. That is why we hold the upgrade.
We expose to connect existing ElasticSearch as you could use any installed version.

Hi. We don't ship ES server/client codes here, we don't directly depends on the ES server (8.5.1 is the Helm Chart version), and, ES is not mandatory required (because we now support using a demo postgresql storage too). Is this still a problem?

@wu-sheng
Copy link
Member

If it is an optional config, we should be fine.

@zalintyre
Copy link
Contributor Author

As the older Elasticsearch Helm template does not run on Kubernetes <= 1.21, I could not deploy Skywalking in our cluster at all. If the postgres backend is not recommended for production, I cannot use that either.

The update to chart version 8.5.1 was a tryout of mine to get Skywalking running. I would appreciate it very much if you could provide a Skywalking version that can be installed on Kubernetes 1.25.

@wu-sheng
Copy link
Member

At least, you could use ElasticSearch official helm to deploy it first, then use our helm to connect the existence ElasticSearch.

@wu-sheng
Copy link
Member

@kezhenxu94 Could you take a look at the ElasticSearch deployment in our helm to upgrade?

@zalintyre
Copy link
Contributor Author

At least, you could use ElasticSearch official helm to deploy it first, then use our helm to connect the existence ElasticSearch.

Thank you for the hint, I will give this a try.

@kezhenxu94
Copy link
Member

Closing in favor of #98

@kezhenxu94 kezhenxu94 closed this Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants