Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a doc to introduce how to use e2e to test itself #119

Merged
merged 11 commits into from
Oct 29, 2023
Merged

Add a doc to introduce how to use e2e to test itself #119

merged 11 commits into from
Oct 29, 2023

Conversation

chunriyeqiongsaigao
Copy link
Contributor

@chunriyeqiongsaigao chunriyeqiongsaigao commented Sep 19, 2023 •
edited

  1. update /test/e2e/concurrency/fail-fast/expected.yaml : use 'subtractor' in /test/e2e/concurrency/failfast/expected.yaml .
  2. add README.md to introduce how to use e2e-test (I will update this doc once I have finished writing it).

@wu-sheng
Copy link
Member

I think you missed the doc update?

@wu-sheng wu-sheng added this to the 1.3.0 milestone Sep 19, 2023
@chunriyeqiongsaigao
Copy link
Contributor Author

I think you missed the doc update?

Thank you very much for the reminder. I will update this doc once I have finished writing it.

@wu-sheng
Copy link
Member

@fgksgf Please take a look.

fgksgf
fgksgf requested changes Sep 26, 2023
View reviewed changes
Copy link
Member

@fgksgf fgksgf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please polish the doc. You can follow this template:

## Introduction

### File Structure

### How it works

## How to add new cases
(use an example)

## Tips

- how to run e2e tests locally
- you may need to split your PR to pass e2e tests in CI
- ...

test/e2e/e2e.yaml Outdated Show resolved Hide resolved
test/e2e/README.md Outdated Show resolved Hide resolved
test/e2e/README.md Outdated Show resolved Hide resolved
test/e2e/README.md Outdated Show resolved Hide resolved
test/e2e/README.md Show resolved Hide resolved
test/e2e/README.md Outdated Show resolved Hide resolved
test/e2e/README.md Outdated Show resolved Hide resolved
@fgksgf fgksgf changed the title update /test/e2e/concurrency/fail-fast/expected.yaml & add README.md to introduce how to use e2e-test Add a doc to introduce how to use e2e to test itself Oct 25, 2023
fgksgf
fgksgf requested changes Oct 25, 2023
View reviewed changes
Makefile Outdated Show resolved Hide resolved
test/e2e/README.md Outdated Show resolved Hide resolved
test/e2e/README.md Outdated Show resolved Hide resolved
test/e2e/README.md Outdated Show resolved Hide resolved
test/e2e/README.md Outdated Show resolved Hide resolved
test/e2e/README.md Outdated Show resolved Hide resolved
fgksgf
fgksgf previously approved these changes Oct 29, 2023
View reviewed changes
Copy link
Member

@fgksgf fgksgf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your contribution!

test/e2e/README.md Outdated Show resolved Hide resolved
@fgksgf fgksgf merged commit 849ab99 into apache:main Oct 29, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fgksgf fgksgf fgksgf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.3.0
3 participants
@chunriyeqiongsaigao @wu-sheng @fgksgf