Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NoSuchMethodError in mvc-annotation-commons&change deprecated method #658

Merged
merged 2 commits into from
Dec 15, 2023

Conversation

CzyerChen
Copy link
Contributor

@CzyerChen CzyerChen commented Dec 14, 2023

Fix NoSuchMethodError in mvc-annotation-commons&change deprecated method

@wu-sheng wu-sheng added bug Something isn't working plugin labels Dec 14, 2023
@wu-sheng wu-sheng added this to the 9.2.0 milestone Dec 14, 2023
@wu-sheng
Copy link
Member

I want to double-check, this test has covered 3.2.18.RELEASE, so, only 3.2.0 had the bug, but 3.2.8 is OK?

@CzyerChen
Copy link
Contributor Author

I want to double-check, this test has covered 3.2.18.RELEASE, so, only 3.2.0 had the bug, but 3.2.8 is OK?

I can write a scenario with version 3.2.18.RELEASE and test again locally.

@wu-sheng
Copy link
Member

The link I provided, it has tested 3.1.4.RELEASE, 3.2.18.RELEASE, 4.0.9.RELEASE, check this, https://github.com/apache/skywalking-java/blob/main/test/plugin/scenarios/spring-3.1.x-scenario/support-version.list.

What I want to confirm with you is, is this test covers your scenario if we add 3.2.0.xx into that? Or 3.2.18 is still having this bug just not covered by the test.

@CzyerChen
Copy link
Contributor Author

The link I provided, it has tested 3.1.4.RELEASE, 3.2.18.RELEASE, 4.0.9.RELEASE, check this, https://github.com/apache/skywalking-java/blob/main/test/plugin/scenarios/spring-3.1.x-scenario/support-version.list.

What I want to confirm with you is, is this test covers your scenario if we add 3.2.0.xx into that? Or 3.2.18 is still having this bug just not covered by the test.

@@ -15,3 +15,5 @@
# limitations under the License.

6.0.4
6.1.0
6.1.1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, only this is using SpringBoot 3.2.0, which was failing before the fix, am I getting your idea correctly?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, I tracd my own springboot project in 3.2.0(Spring 6.1.1), and find SpringMVC node missing, but springboot project in 3.1.6(Spring 6.0.14) works.

@wu-sheng wu-sheng merged commit fdc1e97 into apache:main Dec 15, 2023
184 checks passed
@CzyerChen CzyerChen deleted the bugfix/11652 branch May 11, 2024 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working plugin
Projects
None yet
2 participants