Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.0.0 change #47

Merged
merged 1 commit into from
Mar 26, 2020
Merged

2.0.0 change #47

merged 1 commit into from
Mar 26, 2020

Conversation

innerpeacez
Copy link
Member

No description provided.

@innerpeacez innerpeacez added this to the 2.0.0 milestone Mar 25, 2020
@wu-sheng
Copy link
Member

@innerpeacez Do you submit the wrong request to INFRA? It requires .github/workflows/chart-deploy-ci.yaml task. We can't merge the PR untill INFRA changed it correctly.

@innerpeacez
Copy link
Member Author

innerpeacez commented Mar 25, 2020

Already feedback.And I found that the legacy-helm-chart branch is gone. I don't know why,and I do n’t remember I deleted it. @wu-sheng

@wu-sheng
Copy link
Member

Already feedback.And I found that the legacy-helm-chart branch is gone. I don't know why,and I do n’t remember I deleted it.

Yes. Super strange. I didn't delete it too.

@wu-sheng
Copy link
Member

As those are not Apache release, this is not a big issue. But please remove those words from the readme to avoid mislead.

@innerpeacez
Copy link
Member Author

As those are not Apache release, this is not a big issue. But please remove those words from the readme to avoid mislead.

I still have this branch locally, resubmit this branch?

@wu-sheng
Copy link
Member

I still have this branch locally, resubmit this branch?

You can, and request the branch protection this time.

@innerpeacez
Copy link
Member Author

innerpeacez commented Mar 25, 2020

Done.The strange thing is that the reply from infra was that both the master branch and the legacy-helm-chart branch are protected

@wu-sheng
Copy link
Member

If it is protected, ask Infra about this. We can't delete once it is protected.

@wu-sheng wu-sheng merged commit 66690b7 into apache:master Mar 26, 2020
@innerpeacez innerpeacez deleted the 2.0.0-change branch March 26, 2020 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants