Remove .Values.oap.initEs and replace with Helm Hooks
#95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR also renames |
wu-sheng
approved these changes
Nov 17, 2022
kezhenxu94
force-pushed
the
helm/hook
branch
from
e80897e
to
a41f4e2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.Values.oap.initEswas introduced in #88 to workaround the issue described in apache/skywalking#9290With Helm Chart Hooks we can solve this problem better, this is how it works.
After all resources loaded into Kubernetes, Helm run the
oap-initjob, after theoap-initjob successfully completed, Helm deleteoap-init, next time when you do Helm upgrade, Helm will again deployoap-initjob and when it succeeds Helm will deleteoap-initagain, so there is no error when you redeploy/upgrade SkyWalking deployment.JUST FYI @williamyao1982