add .Values.oap.initEs to work with ES initial #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kezhenxu94
reviewed
Jun 30, 2022
wu-sheng
reviewed
Jun 30, 2022
README.md
Outdated
| @@ -19,6 +19,7 @@ There are required values that you must set explicitly when deploying SkyWalking | |||
| | ---- | ----------- | ------- | | |||
| | `oap.image.tag` | the OAP docker image tag | `9.1.0` | | |||
| | `oap.storageType` | the storage type of the OAP | `elasticsearch`, `postgresql`, etc. | | |||
| | `oap.initEs` | need to initial ES | `true`, `false` | | |||
There was a problem hiding this comment.
Please use ElasticSearch rather than a short term.
|
Besides docs update, you need to fix codes. |
|
My commit already included code change. I provied one argument to control whether the EleasticSearch storage need to be initialized. User can setup .Values.oap.initEs to false when they just want to change the image tag to another one like us. |
|
But your codes can't pass the CI which really run this helm on k8s. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Try to solve this issue apache/skywalking#9290. It will provide the capability to helm upgrade the docker image tag or others after first helm install.